Avoiding upload dev docs when doing releases

[germa89]

While doing v0.64.1 I realise that dev and release documentation are uploaded with the same artefact name, therefore, the artefact get merged and the make pdf generates 2 PDFs.

[codecov]

Codecov Report

Merging #1972 (296cade) into main (f32f3c6) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
- Coverage   86.12%   85.78%   -0.35%     
==========================================
  Files          44       44              
  Lines        7914     7914              
==========================================
- Hits         6816     6789      -27     
- Misses       1098     1125      +27     

[germa89]

LGTM.

[pyansys-ci-bot]

✅ Approving this PR because germa89 said so 😬

[RobPasMue]

Interesting. This shouldn't happen because whenever you do a release you should be on the release/* branch, which means that the first part of the if condition is not satisfied... Have you got an example worflow where this occurred?

[germa89]

You are right. I think I'm missing something...

This log made me think it was something like that:

https://github.com/pyansys/pymapdl/actions/runs/4610641223/jobs/8149372501#step:18:30341

Which has two PDFs:

• https://github.com/pyansys/pymapdl/actions/runs/4610641223/jobs/8149372501#step:21:7361
• https://github.com/pyansys/pymapdl/actions/runs/4610641223/jobs/8149372501#step:21:7350

I guess because there is two PDFs, the test function fail?

I have also seen something similar in:

https://github.com/pyansys/pymapdl/actions/runs/4656136450/jobs/8239493442?pr=1978#step:18:30372

[RobPasMue]

My guess is that this is related to caching issues @germa89

https://github.com/pyansys/pymapdl/blob/8f93fcd810875f378f5f859ef1b27348d7dead2b/.github/workflows/ci.yml#L150-L157

It looks like you are using previously cached directories from the main branch and that's why you are seeing PDFs build from 0.64.1 and 0.65.dev0

I would recommend to either clean the LaTeX build directory first or avoid caching this _build directory.

[germa89]

I did clean it in the past, and it worked. But what it is surprising is that the cache name depends on the PYMAPDL_VERSION, which is different for both.

I will clean it for now. Let's see how it goes.

Thank you @RobPasMue for having a look! :)