Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing whitespace bug in IGESIN. #1976

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Fixing whitespace bug in IGESIN. #1976

merged 7 commits into from
Apr 12, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 6, 2023

As the title.

Close #1601

@germa89 germa89 requested a review from clatapie April 6, 2023 01:24
@germa89 germa89 self-assigned this Apr 6, 2023
@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1976 (0e1f366) into main (f32f3c6) will decrease coverage by 0.37%.
The diff coverage is 30.76%.

❗ Current head 0e1f366 differs from pull request most recent head 0b1933e. Consider uploading reports for the commit 0b1933e to get more accurate results

@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   86.12%   85.76%   -0.37%     
==========================================
  Files          44       44              
  Lines        7914     7916       +2     
==========================================
- Hits         6816     6789      -27     
- Misses       1098     1127      +29     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@germa89 germa89 merged commit 4b289d5 into main Apr 12, 2023
20 checks passed
@germa89 germa89 deleted the fix/white-spaces-in-igesin branch April 12, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launch_mapdl().igesin(fname) strips white spaces from path string
2 participants