Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods for nodes location in current cs and nodes rotation #1978

Merged
merged 16 commits into from
Apr 12, 2023
Merged

Methods for nodes location in current cs and nodes rotation #1978

merged 16 commits into from
Apr 12, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 6, 2023

As the title.

@germa89 germa89 self-assigned this Apr 6, 2023
@germa89 germa89 requested a review from clatapie April 6, 2023 03:20
@germa89 germa89 added the New Feature Request or proposal for a new feature label Apr 6, 2023
@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature labels Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023 •
edited

Codecov Report

Merging #1978 (819f54d) into main (f32f3c6) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
- Coverage   86.12%   85.93%   -0.20%     
==========================================
  Files          44       44              
  Lines        7914     7927      +13     
==========================================
- Hits         6816     6812       -4     
- Misses       1098     1115      +17

clatapie
clatapie reviewed Apr 6, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
clatapie
clatapie approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are missing for the new functions (nodes_in_current_CS, nodes_in_coordinate_system, nodes_rotation).
Apart from that, LGTM 👍

@germa89 germa89 merged commit a8756be into main Apr 12, 2023
27 checks passed
@germa89 germa89 deleted the feat/methods-for-nodes-location-in-current-CS branch April 12, 2023 06:56
@germa89 germa89 mentioned this pull request Apr 24, 2023
Closed
3 tasks
@germa89 germa89 mentioned this pull request May 3, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
Dependencies Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @clatapie