-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contribution.rst #1992
Update contribution.rst #1992
Conversation
Update the email address for support and explain how to switch to different versions of the doc.
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
- Coverage 86.12% 82.98% -3.15%
==========================================
Files 44 44
Lines 7914 7932 +18
==========================================
- Hits 6816 6582 -234
- Misses 1098 1350 +252 |
Hi Kathy I'm happy with these changes. The coverage decreases because the "local" tests fail which is supposed to increase coverage. Hence only coverage of PyMAPDL working as remote is being used. Once we rerun the test successfully, coverage should not change. You can edit the files in devcontainer and docker directories as normal directories. Please add the changes and I will review them Thank you! |
Regarding:
I just changed.
Because (I believe) this email address is going to be deprecated, I would replace this link. It is actually used but you need to look for it without the heading underscore (
I just changed it.
I just changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update the email address for support and explain how to switch to different versions of the doc.
@germa89 I talked to Roberto about making the changes that I've made in this PR before Zurich--and he agreed. I searched the PyMAPDL directory and found that the pyansy.support@pyansy.com also appears in these files:
Should these email addresses also be changed to pyansys.core@pyansys.com? I could easily handle the changes myself, except maybe the first and last ones? I'm not sure if I can edit files in a devcontainer or a Dockerfile.
Also, I have no idea why my changes would reduce the code coverage by 8%. I'd love to understand why this occurred!