Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing not passing comp to the nodal_values function #1997

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 18, 2023

I dont really know how did I miss this.

@mikerife I believe this fix the main issue in #1974, however, can you give it a try? Does it simplify the example you gave in that issue?

Close #1974

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Apr 18, 2023
@germa89 germa89 requested a review from mikerife April 18, 2023 01:57
@germa89 germa89 self-assigned this Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1997 (8154ced) into main (a25fa9e) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
- Coverage   82.98%   82.80%   -0.18%     
==========================================
  Files          44       44              
  Lines        7932     7932              
==========================================
- Hits         6582     6568      -14     
- Misses       1350     1364      +14     

@germa89 germa89 requested a review from clatapie April 19, 2023 10:48
@germa89 germa89 enabled auto-merge (squash) April 19, 2023 10:48
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@germa89 germa89 merged commit 05d2fc0 into main Apr 20, 2023
23 checks passed
@germa89 germa89 deleted the fix/Not-passing-comp-to-nodal_values-function branch April 20, 2023 08:27
@mikerife
Copy link

@germa89
I still get a "TypeError: nodal_values() got multiple values for argument 'comp'" when plotting magnetic flux density component (x). With:

mapdl.post_processing.plot_nodal_values('b','x')

On MAPDL 2023R1, PyMAPDL 0.64.1, Windows 10

Mike

germa89 added a commit that referenced this pull request May 22, 2023
* Fixing not passing comp to the ``nodal_values`` function

* Adding tests and fixing passing arguments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in plot_nodal_values
3 participants