Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for VTK v8 #2000

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Drop support for VTK v8 #2000

merged 1 commit into from
Apr 19, 2023

Conversation

akaszynski
Copy link
Collaborator

PyVista v0.39.0 will be released by 1 May and will drop support for VTK v8. We have one minor change to make to be compatible with the to-be-released package.

@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #2000 (5d24ca3) into main (a25fa9e) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
+ Coverage   82.98%   83.11%   +0.13%     
==========================================
  Files          44       44              
  Lines        7932     7929       -3     
==========================================
+ Hits         6582     6590       +8     
+ Misses       1350     1339      -11     

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 75cf2fd into main Apr 19, 2023
26 checks passed
@germa89 germa89 deleted the fix/drop-vtk8 branch April 19, 2023 10:30
@germa89
Copy link
Collaborator

germa89 commented Apr 19, 2023

Such a nice number for a PR.

@germa89
Copy link
Collaborator

germa89 commented Apr 19, 2023

Interestingly, I think we have been fooled by the cache action:

https://github.com/pyansys/pymapdl/actions/runs/4742338804/jobs/8420894534?pr=1995#step:13:14502

germa89 pushed a commit that referenced this pull request May 22, 2023
drop support for vtk v8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants