Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic_dpf_example.py #2008

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Update basic_dpf_example.py #2008

merged 12 commits into from
Aug 7, 2023

Conversation

akaszynski
Copy link
Collaborator

Fix #2007 by removing connect_to_server.

@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2008 (1a0672f) into main (2221a7b) will decrease coverage by 4.56%.
Report is 75 commits behind head on main.
The diff coverage is 89.12%.

@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
- Coverage   86.43%   81.88%   -4.56%     
==========================================
  Files          45       45              
  Lines        7971     8296     +325     
==========================================
- Hits         6890     6793      -97     
- Misses       1081     1503     +422     

@germa89
Copy link
Collaborator

germa89 commented Apr 23, 2023

Pinging DPF-core to lower versions does not help (I tried up to 0.7.4).
The only way to avoid this error is to ping it lower that 0.7.0. which I feel it is too much.

Until ansys/pydpf-core#908 is released (>0.8.1) we cannot avoid connect_to_server function.
https://github.com/ansys/pydpf-core/releases

Pinging @PProfizi for input.

In the meantime, we shall wait.

@germa89 germa89 requested review from clatapie and germa89 and removed request for clatapie April 26, 2023 03:48
@germa89 germa89 added the Waiting label May 8, 2023
@github-actions github-actions bot removed the WAITING label May 8, 2023
@PProfizi
Copy link
Contributor

PProfizi commented Aug 7, 2023

Hey @germa89,
I think your issue here should be solvable by doing what was done in this PR.
PyDPF-Core 0.9.0 includes a fix regarding upload of files to a server-side temporary folder.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@germa89 germa89 enabled auto-merge (squash) August 7, 2023 17:04
@germa89 germa89 merged commit 1f23bf5 into main Aug 7, 2023
23 checks passed
@germa89 germa89 deleted the docs/fix-dpf-example branch August 7, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPF Example does not need connect_to_server
3 participants