Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving env var section #2014

Merged
merged 5 commits into from
Apr 24, 2023
Merged

Improving env var section #2014

merged 5 commits into from
Apr 24, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 23, 2023

Improving documentation about env vars

@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Apr 23, 2023
@germa89 germa89 requested review from PipKat and clatapie April 23, 2023 15:10
@germa89 germa89 enabled auto-merge (squash) April 23, 2023 15:10
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2014 (f708755) into main (a25fa9e) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
- Coverage   82.98%   82.77%   -0.21%     
==========================================
  Files          44       44              
  Lines        7932     7850      -82     
==========================================
- Hits         6582     6498      -84     
- Misses       1350     1352       +2     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 6b4f020 into main Apr 24, 2023
23 checks passed
@germa89 germa89 deleted the doc/adding-env-vars branch April 24, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants