Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicated code #2016

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Removing duplicated code #2016

merged 7 commits into from
Apr 25, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 24, 2023

Close #1563

@germa89 germa89 added the Enhancement Improve any current implemented feature label Apr 24, 2023
@germa89 germa89 requested a review from akaszynski April 24, 2023 10:55
@germa89 germa89 self-assigned this Apr 24, 2023
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2016 (59e2f54) into main (a25fa9e) will increase coverage by 0.15%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
+ Coverage   82.98%   83.13%   +0.15%     
==========================================
  Files          44       44              
  Lines        7932     7828     -104     
==========================================
- Hits         6582     6508      -74     
+ Misses       1350     1320      -30     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit 3db0652 into main Apr 25, 2023
24 checks passed
@germa89 germa89 deleted the feat/removing-duplicated-code branch April 25, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post and results are duplicated in Mapdl and Mapdlgrpc
2 participants