Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all the subtitles even if they are empty. #2017

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 24, 2023

As the title.

Close #1356

@germa89 germa89 self-assigned this Apr 24, 2023
@germa89 germa89 requested a review from pthieffry April 24, 2023 11:29
@germa89 germa89 added the Enhancement Improve any current implemented feature label Apr 24, 2023
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2017 (662ffa1) into main (a25fa9e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
+ Coverage   82.98%   83.00%   +0.02%     
==========================================
  Files          44       44              
  Lines        7932     7851      -81     
==========================================
- Hits         6582     6517      -65     
+ Misses       1350     1334      -16     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 99972da into main Apr 24, 2023
23 checks passed
@germa89 germa89 deleted the fix/improving-stitle-handling branch April 24, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content of mapdl.info.stitles not fully consistent with /stitle definitions
2 participants