Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to use input and input_strings inside non_interactive #2022

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 25, 2023

Allowing to use input and input_strings inside non_interactive context manager.

Close #1246

@germa89 germa89 requested a review from akaszynski April 25, 2023 08:37
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #2022 (236d53b) into main (a25fa9e) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2022      +/-   ##
==========================================
- Coverage   82.98%   82.85%   -0.14%     
==========================================
  Files          44       44              
  Lines        7932     7866      -66     
==========================================
- Hits         6582     6517      -65     
+ Misses       1350     1349       -1     

@germa89 germa89 self-assigned this Apr 25, 2023
@germa89 germa89 requested review from clatapie and removed request for akaszynski April 25, 2023 14:55
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@germa89 germa89 merged commit 0475292 into main Apr 25, 2023
24 checks passed
@germa89 germa89 deleted the fix/running-input_strings-inside-a-non_interactive-env branch April 25, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input_strings fails to find temporary input file (in docker setting)
2 participants