Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing checking_valid_IP on MapdlGrpc classs #2025

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 26, 2023

Close #1233

@germa89 germa89 changed the title Feat/checking-valid-IP-on-MapdlGrpc-classs Implementing checking_valid_IP on MapdlGrpc classs Apr 26, 2023
@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Apr 26, 2023
@germa89 germa89 requested a review from clatapie April 26, 2023 03:47
@germa89 germa89 self-assigned this Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2025 (7e5cef3) into main (a25fa9e) will decrease coverage by 0.17%.
The diff coverage is 98.36%.

@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
- Coverage   82.98%   82.81%   -0.17%     
==========================================
  Files          44       44              
  Lines        7932     7834      -98     
==========================================
- Hits         6582     6488      -94     
+ Misses       1350     1346       -4     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit 6bc2942 into main Apr 26, 2023
24 checks passed
@germa89 germa89 deleted the feat/checking-valid-IP-on-MapdlGrpc-classs branch April 26, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hostname resolution at the MAPDL class level
2 participants