Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding non_interactive documentation #2026

Merged
merged 3 commits into from
May 3, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 26, 2023

Close #1164

@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2026 (7a5ce70) into main (a25fa9e) will increase coverage by 0.79%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
+ Coverage   82.98%   83.77%   +0.79%     
==========================================
  Files          44       45       +1     
  Lines        7932     7938       +6     
==========================================
+ Hits         6582     6650      +68     
+ Misses       1350     1288      -62     

@germa89 germa89 requested a review from clatapie April 26, 2023 07:04
@germa89 germa89 self-assigned this Apr 26, 2023
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

germa89 and others added 2 commits April 26, 2023 21:47
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@germa89 germa89 merged commit 832a1f2 into main May 3, 2023
24 checks passed
@germa89 germa89 deleted the doc/expanding-non-interactive-context-documentation branch May 3, 2023 11:29
germa89 added a commit that referenced this pull request May 22, 2023
* Expanding non_interactive documentation

* Apply suggestions from code review

Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>

* Removing duplicated documented class

---------

Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the documentation for the non_interactive context
2 participants