Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using common uploader functions in TBFT method #2027

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 26, 2023

Useful reference #1080

Close #1184

@germa89 germa89 changed the title Using common uploader functions Using common uploader functions in TBFT method Apr 26, 2023
@germa89 germa89 requested a review from clatapie April 26, 2023 04:23
@germa89 germa89 self-assigned this Apr 26, 2023
@germa89 germa89 added the Enhancement Improve any current implemented feature label Apr 26, 2023
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2027 (959a2fb) into main (a25fa9e) will increase coverage by 0.20%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
+ Coverage   82.98%   83.18%   +0.20%     
==========================================
  Files          44       44              
  Lines        7932     7839      -93     
==========================================
- Hits         6582     6521      -61     
+ Misses       1350     1318      -32     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@germa89 germa89 merged commit 35e6379 into main Apr 26, 2023
27 checks passed
@germa89 germa89 deleted the feat/upload-file-in-tbft-command branch April 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic file uploads in TBFT command.
2 participants