Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing >22.2 versions for database module #2035

Merged
merged 2 commits into from
May 3, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 28, 2023

Allowing to run database module in versions higher than v22.2

@germa89 germa89 self-assigned this Apr 28, 2023
@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #2035 (d21bb98) into main (a25fa9e) will decrease coverage by 1.15%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   82.98%   81.83%   -1.15%     
==========================================
  Files          44       45       +1     
  Lines        7932     7939       +7     
==========================================
- Hits         6582     6497      -85     
- Misses       1350     1442      +92     

Copy link

@pthieffry pthieffry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The min version will be easier to manage than fixed version number. Thanks for fixing it!

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! 👍

@germa89 germa89 merged commit 5e71fa1 into main May 3, 2023
23 checks passed
@germa89 germa89 deleted the fix/allowing-database-in->v22.2 branch May 3, 2023 11:57
germa89 added a commit that referenced this pull request May 22, 2023
Allowing >22.2 versions for database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants