Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making contains method case insenstive #2039

Merged
merged 3 commits into from
May 3, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 3, 2023

As the title.

So we can do:

mapdl.parameters["mypar"] = 1234
assert "mypar" in mapdl.parameters # True
assert "MYPAR" in mapdl.parameters # True also

@germa89 germa89 self-assigned this May 3, 2023
@germa89 germa89 requested a review from clatapie May 3, 2023 11:26
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #2039 (29305dc) into main (a25fa9e) will increase coverage by 1.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
+ Coverage   82.98%   83.99%   +1.01%     
==========================================
  Files          44       45       +1     
  Lines        7932     7933       +1     
==========================================
+ Hits         6582     6663      +81     
+ Misses       1350     1270      -80     

@germa89 germa89 enabled auto-merge (squash) May 3, 2023 11:57
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit a668b80 into main May 3, 2023
27 checks passed
@germa89 germa89 deleted the fix/adding-more-tests-to-parameters branch May 3, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants