Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing component manager #2041

Merged
merged 63 commits into from
Jul 4, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 3, 2023

Same as parameters.

It should facilitate its usage. However, because we are working python, it probably better to use python lists to store ids.

my_nodes= [1, 2, 3]
mapdl.nsel("S","",my_nodes)

instead of:

mapdl.components["my_nodes"] = "nodes", [1,2,3]

But if we are working with workbench files (ds.dat) files I think this will be appreciated.

Close #1404

@germa89 germa89 added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels May 3, 2023
@germa89 germa89 self-assigned this May 3, 2023
@germa89
Copy link
Collaborator Author

germa89 commented May 3, 2023

Feedback is appreciated @koubaa @akaszynski

However I promised to work on something else this week (which I didn't know it had less days) so I might post-pone this for later. I did this during my last flight so...

@germa89 germa89 marked this pull request as draft May 16, 2023 15:04
@germa89 germa89 mentioned this pull request May 31, 2023
4 tasks
@germa89 germa89 mentioned this pull request Jul 3, 2023
src/ansys/mapdl/core/_commands/database/components.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/component.py Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator Author

germa89 commented Jul 4, 2023

@clatapie ... again mapdl.download giving issues...

germa89 and others added 2 commits July 4, 2023 13:46
Co-authored-by: Jamil Hajjar <hajjarjamil4@gmail.com>
@Gryfenfer97
Copy link
Contributor

If you want to have "" as an option you should add "" in the Literal: Literal["VOLU", ..., "NODE", ""] or add another literal with "" in the union:
Union[Literal["VOLU", ..., "NODE"], Literal[""]]
This is probably why black cannot parse the file

@germa89 germa89 merged commit 2cb4c78 into main Jul 4, 2023
21 checks passed
@germa89 germa89 deleted the feat/implementing-component-manager branch July 4, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components are not implemented in mesh module.
4 participants