Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tests #2042

Merged
merged 5 commits into from
May 4, 2023
Merged

Windows tests #2042

merged 5 commits into from
May 4, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 4, 2023

This is a routinary PR. After quite a few time without checking on Windows side, I decided to run all the tests locally.

Accomplishments:

@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature labels May 4, 2023
@germa89 germa89 requested a review from clatapie May 4, 2023 11:39
@germa89 germa89 self-assigned this May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #2042 (52145e1) into main (a25fa9e) will increase coverage by 3.41%.
The diff coverage is 98.19%.

@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
+ Coverage   82.98%   86.39%   +3.41%     
==========================================
  Files          44       45       +1     
  Lines        7932     7960      +28     
==========================================
+ Hits         6582     6877     +295     
+ Misses       1350     1083     -267     

@germa89 germa89 enabled auto-merge (squash) May 4, 2023 13:40
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit 67b1f6f into main May 4, 2023
27 checks passed
@germa89 germa89 deleted the fix/windows-tests branch May 4, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open_gui() Crashes
2 participants