Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dependencies #2054

Merged
merged 6 commits into from
May 30, 2023
Merged

Fixing dependencies #2054

merged 6 commits into from
May 30, 2023

Conversation

clatapie
Copy link
Contributor

@clatapie clatapie commented May 9, 2023

  • ansys-tools-path needs to be updated because of this issue.
  • pyvista needs to be <0.39 because of this issue.
  • Sphinx needs to be ==6.2.1 because of ansys-sphinx-themeas mentioned here

@clatapie clatapie self-assigned this May 9, 2023
@github-actions github-actions bot added Dependencies Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels May 9, 2023
@clatapie
Copy link
Contributor Author

clatapie commented May 9, 2023

I am encountering this error when building the documentation:

(.venv) PS D:\repos\pyansys\pymapdl_1> .\doc\make.bat html
Running Sphinx v6.2.1
Using pandoc version: 2.19.2 to convert rst text blocks to markdown for .ipynb files
[autosummary] generating autosummary for: 404.rst, api\_autosummary\ansys.mapdl.core.Mapdl.add_file_handler.rst, api\_autosummary\ansys.mapdl.core.Mapdl.aplot.rst, 
api\_autosummary\ansys.mapdl.core.Mapdl.chain_commands.rst, api\_autosummary\ansys.mapdl.core.Mapdl.directory.rst, api\_autosummary\ansys.mapdl.core.Mapdl.eplot.rst, api\_autosummary\ansys.mapdl.core.Mapdl.get.rst, api\_autosummary\ansys.mapdl.core.Mapdl.get_array.rst, api\_autosummary\ansys.mapdl.core.Mapdl.get_value.rst, api\_autosummary\ansys.mapdl.core.Mapdl.ignore_errors.rst, ..., user_guide\mapdl_examples.rst, user_guide\math.rst, user_guide\mesh_geometry.rst, user_guide\parameters.rst, user_guide\plotting.rst, user_guide\pool.rst, user_guide\post.rst, user_guide\troubleshoot.rst, user_guide\upf.rst, user_guide\xpl.rst
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
loading intersphinx inventory from https://docs.scipy.org/doc/scipy/objects.inv...
loading intersphinx inventory from https://numpy.org/doc/stable/objects.inv...
loading intersphinx inventory from https://matplotlib.org/stable/objects.inv...
loading intersphinx inventory from https://pandas.pydata.org/docs/objects.inv...
loading intersphinx inventory from https://docs.pyvista.org/version/stable/objects.inv...    
loading intersphinx inventory from https://grpc.github.io/grpc/python/objects.inv...
loading intersphinx inventory from https://pypim.docs.pyansys.com/objects.inv...
loading intersphinx inventory from https://dpf.docs.pyansys.com/version/stable/objects.inv...
generating gallery...
generating gallery for examples\gallery_examples... 
(.venv) PS D:\repos\pyansys\pymapdl_1> _examples\00-mapdl-examples... [  5%] 2d_plate_with_a_hole.py

The building just stops. Let's investigate if it is a local installation problem or a PyMAPDL related issue.

@clatapie clatapie marked this pull request as draft May 9, 2023 15:54
@germa89
Copy link
Collaborator

germa89 commented May 10, 2023

It seems it builds now

@clatapie
Copy link
Contributor Author

The following error is the one that I've got when running the examples:

File "D:\repos\pyansys\pymapdl_1\.venv\lib\site-packages\ansys\tools\path\path.py", line 679, in _migrate_config_file
    new_config_data = _read_config_file(product_name)
  File "D:\repos\pyansys\pymapdl_1\.venv\lib\site-packages\ansys\tools\path\path.py", line 652, in _read_config_file
    _migrate_config_file(product_name)
  File "D:\repos\pyansys\pymapdl_1\.venv\lib\site-packages\ansys\tools\path\path.py", line 675, in _migrate_config_file
    with open(old_config_file) as f:
RecursionError: maximum recursion depth exceeded while calling a Python object

Let's find why this error is raised.

@clatapie clatapie added DO NOT MERGE Not ready to be merged yet labels May 10, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2054 (7c394d2) into main (a25fa9e) will increase coverage by 3.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2054      +/-   ##
==========================================
+ Coverage   82.98%   86.40%   +3.42%     
==========================================
  Files          44       45       +1     
  Lines        7932     7959      +27     
==========================================
+ Hits         6582     6877     +295     
+ Misses       1350     1082     -268     

@clatapie
Copy link
Contributor Author

The error is now fixed locally with Windows.

@clatapie clatapie marked this pull request as ready for review May 25, 2023 07:16
pyproject.toml Outdated Show resolved Hide resolved
@clatapie clatapie requested a review from RobPasMue May 25, 2023 14:54
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@germa89 germa89 enabled auto-merge (squash) May 30, 2023 10:48
@germa89 germa89 merged commit bda0f9d into main May 30, 2023
22 checks passed
@germa89 germa89 deleted the fix/updating_dependencies branch May 30, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Dependencies DO NOT MERGE Not ready to be merged yet Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants