Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cpxmod field to eigs function in math module #2074

Merged
merged 6 commits into from
May 31, 2023

Conversation

Gryfenfer97
Copy link
Contributor

fix #1166
I chose not to check the value of algo to know if we can apply cpxmod in the MODOPT command as it is already handle by MAPDL, but this behavior could be changed.

@Gryfenfer97 Gryfenfer97 requested a review from germa89 May 25, 2023 14:58
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2074 (fae50f4) into main (a25fa9e) will increase coverage by 3.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
+ Coverage   82.98%   86.42%   +3.44%     
==========================================
  Files          44       45       +1     
  Lines        7932     7971      +39     
==========================================
+ Hits         6582     6889     +307     
+ Misses       1350     1082     -268     

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose not to check the value of algo to know if we can apply cpxmod in the MODOPT command as it is already handle by MAPDL, but this behavior could be changed.

I agree. Most of times, MAPDL handling stuff is preferable, unless there is an incompatibility with PyMAPDL or we are really improving something on MAPDL (plottting for example). But, PyMAPDL should ALWAYS follow MAPDL guidance.

LGTM. Just a small comment.

src/ansys/mapdl/core/math.py Show resolved Hide resolved
@germa89 germa89 added the Enhancement Improve any current implemented feature label May 30, 2023
@germa89 germa89 enabled auto-merge (squash) May 30, 2023 11:08
@germa89 germa89 merged commit 1a8e9d3 into main May 31, 2023
24 checks passed
@germa89 germa89 deleted the fix/cpxmod-field-for-eigs branch May 31, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the "CPXMOD" field of the MODOPT command for EIGS
3 participants