Fixing missing full file #2083
Merged
Fixing missing full file #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
Codecov Report
@@ Coverage Diff @@
## main #2083 +/- ##
==========================================
+ Coverage 82.98% 86.50% +3.52%
==========================================
Files 44 45 +1
Lines 7932 7959 +27
==========================================
+ Hits 6582 6885 +303
+ Misses 1350 1074 -276 |
|
Ohh.. Now I know why the CICD didn't catch it. Because the examples didn't change! It was the verification manual files, which were called directly from the example scripts. But those scripts didn't change. Jeezzzz.. I'm slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the old
vm153.dathad the full file name embedded.When the vms were updated in #2045, the command which changed the full file was deleted:
CICD should have catch this, but it reused the cached examples. I'm not sure how to solve that. I will open a different issue for that.
Close #2078