Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing upper version limit #2094

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Fixing upper version limit #2094

merged 2 commits into from
Jun 2, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 1, 2023

We are making the version upper bound time dependent.

@germa89 germa89 requested a review from clatapie June 1, 2023 11:33
@germa89 germa89 self-assigned this Jun 1, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature labels Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #2094 (569f2ac) into main (a25fa9e) will decrease coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2094      +/-   ##
==========================================
- Coverage   82.98%   82.09%   -0.89%     
==========================================
  Files          44       45       +1     
  Lines        7932     7971      +39     
==========================================
- Hits         6582     6544      -38     
- Misses       1350     1427      +77     

@germa89 germa89 enabled auto-merge (squash) June 1, 2023 13:49
@clatapie clatapie disabled auto-merge June 2, 2023 09:50
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 enabled auto-merge (squash) June 2, 2023 10:02
@germa89 germa89 merged commit 89e2d2d into main Jun 2, 2023
24 checks passed
@germa89 germa89 deleted the fix/upper-version branch June 2, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants