Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a section to convert the app to an executable to examples #2100

Merged
merged 16 commits into from
Jun 16, 2023

Conversation

Gryfenfer97
Copy link
Contributor

No description provided.

@Gryfenfer97 Gryfenfer97 requested a review from germa89 June 2, 2023 15:06
@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2100 (a07eb05) into main (09d55a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2100   +/-   ##
=======================================
  Coverage   86.43%   86.44%           
=======================================
  Files          45       45           
  Lines        7971     7981   +10     
=======================================
+ Hits         6890     6899    +9     
- Misses       1081     1082    +1     

@germa89 germa89 requested a review from clatapie June 5, 2023 07:33
@germa89
Copy link
Collaborator

germa89 commented Jun 5, 2023

@clatapie please do review this PR too. Thank you!

@Gryfenfer97
Copy link
Contributor Author

Gryfenfer97 commented Jun 5, 2023

The error comes from the argument datas of Analysis of pyinstaller.
It should be data (for codespell) but changing it would make the code incorrect

@clatapie
Copy link
Contributor

clatapie commented Jun 7, 2023

When a word that you need is not accepted by codespell, you can manually add it to its accepted words dictionary in the file doc/styles/Vocab/ANSYS/accept.txt

The error comes from the argument datas of Analysis of pyinstaller. It should be data (for codespell) but changing it would make the code incorrect

@Gryfenfer97
Copy link
Contributor Author

When a word that you need is not accepted by codespell, you can manually add it to its accepted words dictionary in the file doc/styles/Vocab/ANSYS/accept.txt

The error comes from the argument datas of Analysis of pyinstaller. It should be data (for codespell) but changing it would make the code incorrect

I wasn't sure about doing that because data is a word where it's easy to make a mistake and write datas. That's why I waited for your answer to know if I can add this in the list.
I am adding the word.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the documentation is sort of complete. Someone reading the document should understand why we are doing what we are doing. For further details you should give links which the user can follow easy.

Please address the comments and ping me when ready.

@germa89 germa89 requested a review from PipKat June 12, 2023 15:33
@germa89
Copy link
Collaborator

germa89 commented Jun 12, 2023

Pinging @PipKat for documentation review.

Gryfenfer97 and others added 2 commits June 13, 2023 10:10
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added doc review comments per @germa89's request.

Gryfenfer97 and others added 4 commits June 13, 2023 17:41
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me 👍

@Gryfenfer97
Copy link
Contributor Author

@germa89

@germa89 germa89 self-requested a review June 16, 2023 08:37
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just fix/close the conversation we have still open. Also there are some Vale warnings regarding the ellipsis. You can use .. vale off and .. vale on to hide them.

@germa89 germa89 enabled auto-merge (squash) June 16, 2023 08:38
@germa89 germa89 merged commit b38593e into main Jun 16, 2023
20 of 21 checks passed
@germa89 germa89 deleted the example/executable-without-python branch June 16, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants