Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing math module calls into ansys-math-core ones #2102

Merged
merged 27 commits into from
Jun 19, 2023
Merged

Changing math module calls into ansys-math-core ones #2102

merged 27 commits into from
Jun 19, 2023

Conversation

clatapie
Copy link
Contributor

@clatapie clatapie commented Jun 5, 2023

Closes #2087.

@clatapie clatapie self-assigned this Jun 5, 2023
@clatapie clatapie linked an issue Jun 5, 2023 that may be closed by this pull request
Replace math module with ansys-math-core library #2087
Closed
@clatapie clatapie added Enhancement Improve any current implemented feature DO NOT MERGE Not ready to be merged yet labels Jun 5, 2023
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) New Feature Request or proposal for a new feature labels Jun 5, 2023
@clatapie clatapie mentioned this pull request Jun 7, 2023
Closed
2 tasks
@clatapie
Copy link
Contributor Author

clatapie commented Jun 7, 2023

The test_krylov is failing in the CICD because of an error in PyAnsys Math. It will be fixed with ansys/pyansys-math#115. Once merged, a patch release will be planned.

@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited

Codecov Report

Merging #2102 (9b4a34c) into main (09d55a4) will decrease coverage by 0.73%.
The diff coverage is 95.16%.

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   86.43%   85.71%   -0.73%     
==========================================
  Files          45       44       -1     
  Lines        7971     7414     -557     
==========================================
- Hits         6890     6355     -535     
+ Misses       1081     1059      -22

@clatapie clatapie marked this pull request as ready for review June 16, 2023 14:18
@clatapie
Copy link
Contributor Author

As documentation sections are impacted by this PR, I am pinging @PipKat for a documentation review.

@clatapie clatapie requested a review from PipKat June 16, 2023 15:10
germa89
germa89 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

doc/source/user_guide/math.rst Outdated Show resolved Hide resolved
src/ansys/mapdl/core/krylov.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
PipKat
PipKat approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor edits!

RobPasMue
RobPasMue approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Solve also related Vale warnings if possible @clatapie

clatapie and others added 3 commits June 19, 2023 09:06
@clatapie @PipKat
Apply suggestions from code review
8b16582 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@clatapie
Applying changes from German's review
6f9a8f0
@clatapie
Fixing Vale warning
cacd014
@clatapie clatapie enabled auto-merge (squash) June 19, 2023 09:54
@clatapie clatapie merged commit 7ce6d7d into main Jun 19, 2023
21 checks passed
@clatapie clatapie deleted the feat/replace_mapdl_math branch June 19, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@germa89 germa89 germa89 approved these changes

@PipKat PipKat PipKat approved these changes

Assignees

@clatapie clatapie

Labels
DO NOT MERGE Not ready to be merged yet Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace math module with ansys-math-core library
4 participants
@clatapie @germa89 @RobPasMue @PipKat