Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace appdirs by platformdirs #2129

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

Gryfenfer97
Copy link
Contributor

In February 2023 appdirs has been deprecated
The developers suggest to move to platformdirs which is a more active fork of appdirs

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2129 (604ff01) into main (09d55a4) will decrease coverage by 0.73%.
The diff coverage is 95.31%.

@@            Coverage Diff             @@
##             main    #2129      +/-   ##
==========================================
- Coverage   86.43%   85.71%   -0.73%     
==========================================
  Files          45       44       -1     
  Lines        7971     7414     -557     
==========================================
- Hits         6890     6355     -535     
+ Misses       1081     1059      -22     

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@germa89 germa89 enabled auto-merge (squash) June 20, 2023 11:08
@germa89 germa89 merged commit ad6072c into main Jun 20, 2023
24 checks passed
@germa89 germa89 deleted the feat/replace-appdirs-with-platformdirs branch June 20, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Dependencies Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants