Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Pyvista for the next release #2140

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fixing Pyvista for the next release #2140

merged 1 commit into from
Jun 27, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 23, 2023 •
edited

Close #2101
Close #2109

@germa89 germa89 self-assigned this Jun 23, 2023
@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited

Codecov Report

Merging #2140 (0ce2348) into main (09d55a4) will decrease coverage by 0.71%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
- Coverage   86.43%   85.73%   -0.71%     
==========================================
  Files          45       44       -1     
  Lines        7971     7411     -560     
==========================================
- Hits         6890     6354     -536     
+ Misses       1081     1057      -24

@germa89 germa89 requested a review from clatapie June 23, 2023 15:02
@germa89
Copy link
Collaborator Author

germa89 commented Jun 23, 2023

Pinging @banesullivan for visibility.

banesullivan
banesullivan reviewed Jun 23, 2023
View reviewed changes
Copy link

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

clatapie
clatapie approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 0902bad into main Jun 27, 2023
25 checks passed
@germa89 germa89 deleted the fix/pyvista-next-release branch June 27, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banesullivan banesullivan banesullivan left review comments

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of pyvista._vtk will break on next release This import test of PyVista is prone to failure
3 participants
@germa89 @banesullivan @clatapie