Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mapdl_download #2147

Merged
merged 74 commits into from
Jun 29, 2023
Merged

Fix/mapdl_download #2147

merged 74 commits into from
Jun 29, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 27, 2023

No description provided.

clatapie and others added 30 commits May 31, 2023 12:44
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@germa89 germa89 requested a review from clatapie June 27, 2023 09:04
@germa89
Copy link
Collaborator Author

germa89 commented Jun 27, 2023

@clatapie because of some messing up with git, your PR has been deleted. I'm sorry about that!

@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2147 (f448437) into main (997e288) will increase coverage by 0.85%.
The diff coverage is 83.83%.

@@            Coverage Diff             @@
##             main    #2147      +/-   ##
==========================================
+ Coverage   80.82%   81.67%   +0.85%     
==========================================
  Files          44       44              
  Lines        7489     7532      +43     
==========================================
+ Hits         6053     6152      +99     
+ Misses       1436     1380      -56     

@germa89 germa89 marked this pull request as ready for review June 28, 2023 13:23
@germa89
Copy link
Collaborator Author

germa89 commented Jun 28, 2023

Finally

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thank you @germa89 !

src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) June 28, 2023 14:28
@germa89 germa89 disabled auto-merge June 28, 2023 14:28
src/ansys/mapdl/core/common_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
Co-authored-by: Jamil Hajjar <hajjarjamil4@gmail.com>
@germa89 germa89 enabled auto-merge (squash) June 29, 2023 09:01
germa89 and others added 2 commits June 29, 2023 11:10
Co-authored-by: Jamil Hajjar <hajjarjamil4@gmail.com>
@germa89 germa89 merged commit 4e5e387 into main Jun 29, 2023
20 of 22 checks passed
@germa89 germa89 deleted the fix/mapdl_download branch June 29, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants