Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing and extending theme. #2170

Merged
merged 9 commits into from
Jul 19, 2023
Merged

Fixing and extending theme. #2170

merged 9 commits into from
Jul 19, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 7, 2023

Adding also tests

Close #2169

@germa89 germa89 self-assigned this Jul 7, 2023
@germa89 germa89 requested a review from clatapie July 7, 2023 10:29
@germa89 germa89 added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #2170 (7367d53) into main (997e288) will increase coverage by 6.31%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##             main    #2170      +/-   ##
==========================================
+ Coverage   80.82%   87.13%   +6.31%     
==========================================
  Files          44       45       +1     
  Lines        7489     8078     +589     
==========================================
+ Hits         6053     7039     +986     
+ Misses       1436     1039     -397     

@germa89
Copy link
Collaborator Author

germa89 commented Jul 7, 2023

To merge after #2125 is merged.

@germa89 germa89 enabled auto-merge (squash) July 10, 2023 12:47
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit c4e942c into main Jul 19, 2023
22 checks passed
@germa89 germa89 deleted the fix/theme branch July 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theme does not work
2 participants