Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pyvista to 0.41 #2194

Merged
merged 20 commits into from
Aug 3, 2023
Merged

Updating pyvista to 0.41 #2194

merged 20 commits into from
Aug 3, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 20, 2023

As the title.

@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels Jul 20, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Jul 20, 2023

this update breaks:

  • PyMAPDL-Reader:
tests/test_mapdl.py:10: in <module>
    from ansys.mapdl.reader.rst import Result
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/ansys/mapdl/reader/rst.py:18: in <module>
    from pyvista.themes import DefaultTheme
E   ModuleNotFoundError: No module named 'pyvista.themes'
  • DPF-Core. This one is actually OK because we only use DPF for testing.
tests/test_dpf.py:4: in <module>
    from ansys.dpf import core as dpf
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/ansys/dpf/core/__init__.py:101: in <module>
    settings.set_default_pyvista_config()
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/ansys/dpf/core/settings.py:35: in set_default_pyvista_config
    pv.rcParams["interactive"] = True
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/pyvista/__init__.py:95: in __getattr__
    raise AttributeError(f"module 'pyvista' has no attribute '{name}'") from None
E   AttributeError: module 'pyvista' has no attribute 'rcParams'

I can fix PyMAPDL reader, but DPF is another story... @PProfizi

So I'm going to fix first PyMAPDL-Reader. ansys/pymapdl-reader#287

@PProfizi
Copy link
Contributor

Hi @germa89, this is already fixed on pydpf-core ;) ansys/pydpf-core#1045

@germa89
Copy link
Collaborator Author

germa89 commented Jul 21, 2023

In the meantime, #2198

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2194 (058d08d) into main (2221a7b) will decrease coverage by 4.56%.
Report is 71 commits behind head on main.
The diff coverage is 89.12%.

@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
- Coverage   86.43%   81.88%   -4.56%     
==========================================
  Files          45       45              
  Lines        7971     8296     +325     
==========================================
- Hits         6890     6793      -97     
- Misses       1081     1503     +422     

tests/test_dpf.py Outdated Show resolved Hide resolved
@clatapie clatapie requested a review from RobPasMue August 3, 2023 14:42
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clatapie clatapie merged commit 5b2d120 into main Aug 3, 2023
23 checks passed
@clatapie clatapie deleted the maint/update-pyvista-to-0.41 branch August 3, 2023 15:09
germa89 added a commit that referenced this pull request Aug 8, 2023
* Updating pyvista to 0.41

* Updating reader

* Removing rcParams

* Using pyvista 0.41.1

* Avoiding importing dpf.

* adding missing import

* Update tests/test_dpf.py

* maint: updating `ansys-dpf-core` version

* test: fixing `test_heal`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test: revert last commit

---------

Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
germa89 added a commit that referenced this pull request Aug 9, 2023
* Updating pyvista to 0.41 (#2194)

* Updating pyvista to 0.41

* Updating reader

* Removing rcParams

* Using pyvista 0.41.1

* Avoiding importing dpf.

* adding missing import

* Update tests/test_dpf.py

* maint: updating `ansys-dpf-core` version

* test: fixing `test_heal`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test: revert last commit

---------

Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Including import into try clause.

---------

Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants