Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumPy version depending on Python version #2200

Merged
merged 3 commits into from
Jul 24, 2023
Merged

NumPy version depending on Python version #2200

merged 3 commits into from
Jul 24, 2023

Conversation

clatapie
Copy link
Contributor

Closes #2199.

@clatapie clatapie requested a review from germa89 July 24, 2023 10:28
@clatapie clatapie linked an issue Jul 24, 2023 that may be closed by this pull request
NumPy doesn't support Python 3.8 anymore #2199
Closed
4 tasks
@clatapie clatapie self-assigned this Jul 24, 2023
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited

Codecov Report

Merging #2200 (2a32e7b) into main (997e288) will increase coverage by 6.39%.
The diff coverage is 95.60%.

@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
+ Coverage   80.82%   87.22%   +6.39%     
==========================================
  Files          44       45       +1     
  Lines        7489     8107     +618     
==========================================
+ Hits         6053     7071    +1018     
+ Misses       1436     1036     -400

@clatapie clatapie enabled auto-merge (squash) July 24, 2023 10:45
germa89
germa89 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@clatapie clatapie merged commit f331f5b into main Jul 24, 2023
22 checks passed
@clatapie clatapie deleted the maint/numpy_python3.8 branch July 24, 2023 11:09
germa89 pushed a commit that referenced this pull request Jul 27, 2023
@clatapie @pre-commit-ci @germa89
NumPy version depending on Python version (#2200)
55e0e2e 
* maint: fix numpy version depending on python version

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* maint: fix dependencies

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

Assignees

@clatapie clatapie

Labels
Dependencies Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NumPy doesn't support Python 3.8 anymore
2 participants
@clatapie @germa89