Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements on the dev containers #2208

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Small improvements on the dev containers #2208

merged 2 commits into from
Jul 25, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 25, 2023

As the title.

@germa89 germa89 self-assigned this Jul 25, 2023
@germa89 germa89 added the Enhancement Improve any current implemented feature label Jul 25, 2023
@germa89 germa89 requested a review from clatapie July 25, 2023 12:14
@germa89 germa89 enabled auto-merge (squash) July 25, 2023 12:14
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited

Codecov Report

Merging #2208 (ac64541) into main (997e288) will increase coverage by 6.22%.
The diff coverage is 95.60%.

@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
+ Coverage   80.82%   87.04%   +6.22%     
==========================================
  Files          44       45       +1     
  Lines        7489     8107     +618     
==========================================
+ Hits         6053     7057    +1004     
+ Misses       1436     1050     -386

@germa89
Copy link
Collaborator Author

germa89 commented Jul 25, 2023

LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 merged commit ad9eed9 into main Jul 25, 2023
25 checks passed
@germa89 germa89 deleted the feat/small-improvements-on-dev-on-container-approach branch July 25, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot