Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing import in queries #2214

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Adding missing import in queries #2214

merged 4 commits into from
Jul 31, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 28, 2023

Close #2209

@germa89 germa89 requested a review from clatapie July 28, 2023 08:50
@germa89 germa89 self-assigned this Jul 28, 2023
@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Jul 28, 2023
@germa89 germa89 enabled auto-merge (squash) July 28, 2023 08:50
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited

Codecov Report

Merging #2214 (01a0ce1) into main (2221a7b) will increase coverage by 1.41%.
Report is 69 commits behind head on main.
The diff coverage is 94.06%.

@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
+ Coverage   86.43%   87.85%   +1.41%     
==========================================
  Files          45       45              
  Lines        7971     8293     +322     
==========================================
+ Hits         6890     7286     +396     
+ Misses       1081     1007      -74

@germa89 germa89 requested a review from clatapie July 31, 2023 10:25
clatapie
clatapie approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@germa89 germa89 merged commit d377392 into main Jul 31, 2023
23 checks passed
@germa89 germa89 deleted the fix/missing-import-in-queries branch July 31, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name 'MapdlRuntimeError' is not defined when trying to use mapdl.noninteractive
2 participants
@germa89 @clatapie