Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing xfails. #2216

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Removing xfails. #2216

merged 1 commit into from
Jul 31, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 28, 2023

The pytest.mark.xfail should be used when the implementation is not correct, or similar. So eventually, this will get fixed.

XFAIL should not be used as a default when the test raises an exception because in that case, the implementation is behaving as expected and it should be a PASS.

@germa89 germa89 self-assigned this Jul 28, 2023
@germa89 germa89 enabled auto-merge (squash) July 28, 2023 09:39
@germa89
Copy link
Collaborator Author

germa89 commented Jul 28, 2023

Requesting so many reviewers just to validate my thoughts about XFAIL.

@github-actions github-actions bot added the Maintenance General maintenance of the repo (libraries, cicd, etc) label Jul 28, 2023
@germa89 germa89 added the Enhancement Improve any current implemented feature label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2216 (c8daeca) into main (2221a7b) will increase coverage by 0.79%.
Report is 62 commits behind head on main.
The diff coverage is 94.25%.

@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
+ Coverage   86.43%   87.22%   +0.79%     
==========================================
  Files          45       45              
  Lines        7971     8245     +274     
==========================================
+ Hits         6890     7192     +302     
+ Misses       1081     1053      -28     

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - avoid using xfail if possible, good approach @germa89

@germa89 germa89 merged commit 3a34ec3 into main Jul 31, 2023
25 checks passed
@germa89 germa89 deleted the maint/remove-xfail branch July 31, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants