Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding v24.1 to cicd #2220

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Adding v24.1 to cicd #2220

merged 3 commits into from
Jul 31, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 31, 2023

As the title.

@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Jul 31, 2023
@germa89 germa89 self-assigned this Jul 31, 2023
@github-actions github-actions bot added the Maintenance General maintenance of the repo (libraries, cicd, etc) label Jul 31, 2023
clatapie
clatapie approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited

Codecov Report

Merging #2220 (7fff016) into main (2221a7b) will decrease coverage by 1.31%.
Report is 68 commits behind head on main.
The diff coverage is 93.40%.

@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
- Coverage   86.43%   85.13%   -1.31%     
==========================================
  Files          45       45              
  Lines        7971     8292     +321     
==========================================
+ Hits         6890     7059     +169     
- Misses       1081     1233     +152

@RobPasMue
Copy link
Member

Yeah... 4.0 doesn't exist 😄

@clatapie clatapie enabled auto-merge (squash) July 31, 2023 16:02
@clatapie clatapie merged commit b05b13d into main Jul 31, 2023
23 checks passed
@clatapie clatapie deleted the ci/add-24.1-to-CICD branch July 31, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

@klmcadams klmcadams Awaiting requested review from klmcadams

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@germa89 @RobPasMue @clatapie