Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing vale warnings #2228

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Fixing vale warnings #2228

merged 2 commits into from
Aug 7, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 7, 2023

As the title.

@germa89 germa89 self-assigned this Aug 7, 2023
@germa89 germa89 requested a review from clatapie August 7, 2023 12:58
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Aug 7, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Aug 7, 2023

LGTM. 🤓

@germa89 germa89 enabled auto-merge (squash) August 7, 2023 13:01
pyansys-ci-bot
pyansys-ci-bot approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited

Codecov Report

Merging #2228 (4b53bfa) into main (2221a7b) will increase coverage by 1.26%.
Report is 73 commits behind head on main.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main    #2228      +/-   ##
==========================================
+ Coverage   86.43%   87.70%   +1.26%     
==========================================
  Files          45       45              
  Lines        7971     8296     +325     
==========================================
+ Hits         6890     7276     +386     
+ Misses       1081     1020      -61

@germa89 germa89 merged commit b5ce567 into main Aug 7, 2023
23 checks passed
@germa89 germa89 deleted the fix/vale-warnings-regarding-corba branch August 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot