Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a body flux example #2233

Merged
merged 18 commits into from
Aug 10, 2023
Merged

Adding a body flux example #2233

merged 18 commits into from
Aug 10, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 8, 2023

As the title.

@clatapie please can you have a look at this example?

@PipKat please could you review the grammar?

@mikerife I had to change some text and reorg a bit. Could you check everything still makes sense?

Thank you all!

Close #1998

@germa89 germa89 self-assigned this Aug 8, 2023
@germa89 germa89 added the Examples Publishing PyMAPDL examples label Aug 8, 2023
@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2233 (63d7e0b) into main (2221a7b) will decrease coverage by 4.56%.
Report is 78 commits behind head on main.
The diff coverage is 89.06%.

@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
- Coverage   86.43%   81.87%   -4.56%     
==========================================
  Files          45       45              
  Lines        7971     8300     +329     
==========================================
- Hits         6890     6796      -94     
- Misses       1081     1504     +423     

@germa89 germa89 requested a review from clatapie August 9, 2023 09:56
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germa89 Provided text edits for consideration.

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) August 9, 2023 18:16
@germa89 germa89 merged commit 07b7c1e into main Aug 10, 2023
23 checks passed
@germa89 germa89 deleted the doc/body-flux-example branch August 10, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc) Examples Publishing PyMAPDL examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example proposal: Body Flux example
4 participants