Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing listing files in build docs. #2251

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Removing listing files in build docs. #2251

merged 1 commit into from
Aug 16, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 16, 2023

This step takes up to 4 minutes. It is too much time for the marginal usage we give it to it.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited

Codecov Report

Merging #2251 (207808d) into main (e3885fb) will increase coverage by 1.44%.
Report is 89 commits behind head on main.
The diff coverage is 93.92%.

@@            Coverage Diff             @@
##             main    #2251      +/-   ##
==========================================
+ Coverage   86.39%   87.83%   +1.44%     
==========================================
  Files          45       45              
  Lines        7977     8338     +361     
==========================================
+ Hits         6892     7324     +432     
+ Misses       1085     1014      -71

@germa89 germa89 requested a review from clatapie August 16, 2023 12:27
@germa89 germa89 enabled auto-merge (squash) August 16, 2023 12:27
@germa89
Copy link
Collaborator Author

germa89 commented Aug 16, 2023

LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 192ffdb into main Aug 16, 2023
26 checks passed
@germa89 germa89 deleted the fix/reducing-log-files-timing branch August 16, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

@Gryfenfer97 Gryfenfer97 Awaiting requested review from Gryfenfer97

Assignees
No one assigned
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot