Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating plotly. #2252

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Updating plotly. #2252

merged 1 commit into from
Aug 16, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 16, 2023 •
edited

As the title. Because I removed it from #2248

@germa89 germa89 requested a review from clatapie August 16, 2023 12:30
@germa89 germa89 self-assigned this Aug 16, 2023
@germa89 germa89 added Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels Aug 16, 2023
@germa89 germa89 enabled auto-merge (squash) August 16, 2023 12:30
@germa89
Copy link
Collaborator Author

germa89 commented Aug 16, 2023

LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited

Codecov Report

Merging #2252 (b97ff20) into main (e3885fb) will increase coverage by 1.32%.
Report is 90 commits behind head on main.
The diff coverage is 93.92%.

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   86.39%   87.71%   +1.32%     
==========================================
  Files          45       45              
  Lines        7977     8338     +361     
==========================================
+ Hits         6892     7314     +422     
+ Misses       1085     1024      -61

@germa89 germa89 merged commit ffbee85 into main Aug 16, 2023
25 checks passed
@germa89 germa89 deleted the maint/update-plotly branch August 16, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

Assignees

@germa89 germa89

Labels
Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@germa89 @clatapie @pyansys-ci-bot