Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extension from file name, and using explicitly the ext field. #2257

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 17, 2023

Close #2256

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Aug 17, 2023
@germa89 germa89 requested a review from clatapie August 17, 2023 11:48
@germa89 germa89 self-assigned this Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2257 (cfb7109) into main (e3885fb) will increase coverage by 1.33%.
Report is 91 commits behind head on main.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   86.39%   87.73%   +1.33%     
==========================================
  Files          45       45              
  Lines        7977     8339     +362     
==========================================
+ Hits         6892     7316     +424     
+ Misses       1085     1023      -62     

@germa89 germa89 enabled auto-merge (squash) August 17, 2023 14:05
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit d0a42b9 into main Aug 18, 2023
26 checks passed
@germa89 germa89 deleted the fix/file-not-opening-correctly-files branch August 18, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ansys.mapdl.core.mapdl_grpc.MapdlGrpc.file() will fail if run with local session
2 participants