Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added distributed test #2263

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Added distributed test #2263

merged 2 commits into from
Aug 18, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 18, 2023

Test that ON_LOCAL is running on distributed (-DMP).

Assumes that ON_REMOTE distributed should be False (because we specify -SMP when launching the docker image) and ON_LOCAL distributed should be True (because it is the default for MAPDL, and we dont specify -SMP).

To test if we are running distribute, we use the *GET command with active and numcpu:

return int(self._mapdl.get_value("ACTIVE", item1="NUMCPU"))

I believe this is the right way.

@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #2263 (1039178) into main (e3885fb) will increase coverage by 1.45%.
Report is 95 commits behind head on main.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
+ Coverage   86.39%   87.85%   +1.45%     
==========================================
  Files          45       45              
  Lines        7977     8339     +362     
==========================================
+ Hits         6892     7326     +434     
+ Misses       1085     1013      -72     

@germa89 germa89 requested a review from koubaa August 18, 2023 15:12
@germa89 germa89 self-assigned this Aug 18, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Aug 18, 2023

LGTM!

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 5b44e6a into main Aug 18, 2023
23 checks passed
@germa89 germa89 deleted the feat/adding-distributed-test branch August 18, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants