Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool improvements #2277

Merged
merged 19 commits into from
Sep 11, 2023
Merged

Pool improvements #2277

merged 19 commits into from
Sep 11, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 28, 2023

Implementing instance name in the directories.

Close #2272
Close #2173

@germa89 germa89 self-assigned this Aug 28, 2023
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2277 (3f4b2d7) into main (a2d1951) will increase coverage by 5.81%.
Report is 1 commits behind head on main.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
+ Coverage   81.79%   87.60%   +5.81%     
==========================================
  Files          45       45              
  Lines        8435     8456      +21     
==========================================
+ Hits         6899     7408     +509     
+ Misses       1536     1048     -488     

@germa89 germa89 marked this pull request as ready for review September 5, 2023 10:41
@germa89
Copy link
Collaborator Author

germa89 commented Sep 7, 2023

Thanks to #2314 I have been able to reduce the testing pool time.

Before 209.84s

(.venv) PS C:\Users\gayuso\pymapdl> pytest -k test_pool
=========================================================================== test session starts ============================================================================ 
platform win32 -- Python 3.10.5, pytest-7.4.0, pluggy-1.0.0
rootdir: C:\Users\gayuso\pymapdl
configfile: pyproject.toml
testpaths: tests
plugins: anyio-3.6.2, cov-4.1.0, rerunfailures-12.0, sphinx-0.5.0
collected 1497 items / 1486 deselected / 11 selected                                                                                                                         

tests\test_pool.py s..........                                                                                                                                        [100%]

======================================================================= PyMAPDL Pytest short summary =======================================================================
======================================================== 10 passed, 1 skipped, 1486 deselected in 209.84s (0:03:29) ========================================================

After 196.39s (WIP)

(.venv) PS C:\Users\gayuso\pymapdl> pytest -k test_pool
======================================================================================= test session starts ======================================================================================= 
platform win32 -- Python 3.10.5, pytest-7.4.0, pluggy-1.0.0
rootdir: C:\Users\gayuso\pymapdl
configfile: pyproject.toml
testpaths: tests
plugins: anyio-3.6.2, cov-4.1.0, rerunfailures-12.0, sphinx-0.5.0
collected 1497 items / 1486 deselected / 11 selected                                                                                                                                                

tests\test_pool.py s..........                                                                                                                                                               [100%]

================================================================================== PyMAPDL Pytest short summary ===================================================================================
=================================================================== 10 passed, 1 skipped, 1486 deselected in 196.39s (0:03:16) ====================================================================

Notes

Locally the time reduction was higher.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 11, 2023

LGTM.

@germa89 germa89 enabled auto-merge (squash) September 11, 2023 16:57
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 04c1637 into main Sep 11, 2023
23 of 24 checks passed
@germa89 germa89 deleted the feat/pool-improvements branch September 11, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pool.run_batch(paths) should create result directories based on the input file name test_heal is flaky
3 participants