Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing nightly doc build #2294

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Removing nightly doc build #2294

merged 2 commits into from
Sep 5, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 1, 2023

Because it is done in the main ci file.

@germa89 germa89 self-assigned this Sep 1, 2023
@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Sep 1, 2023
@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited

Codecov Report

Merging #2294 (c4001be) into main (e3885fb) will increase coverage by 1.20%.
Report is 115 commits behind head on main.
The diff coverage is 91.40%.

@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
+ Coverage   86.39%   87.60%   +1.20%     
==========================================
  Files          45       45              
  Lines        7977     8433     +456     
==========================================
+ Hits         6892     7388     +496     
+ Misses       1085     1045      -40

clatapie
clatapie approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 enabled auto-merge (squash) September 5, 2023 08:11
@germa89 germa89 merged commit 42eaa21 into main Sep 5, 2023
23 checks passed
@germa89 germa89 deleted the feat/removing-nightly-build branch September 5, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

@Gryfenfer97 Gryfenfer97 Awaiting requested review from Gryfenfer97

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @clatapie