Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving SATIN command #2300

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Improving SATIN command #2300

merged 2 commits into from
Sep 4, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 4, 2023

Improving SATIN command by implementing changes on #2285

Close #2285

Testing code:

from ansys.mapdl.core import launch_mapdl
mapdl = launch_mapdl(log_apdl="log.log")

mapdl.satin(name="geom", extension="sat", fmt=0, entity="solid")

print(mapdl.geometry)

Using this file: #2286 (reply in thread)

@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2300 (f94ce94) into main (e3885fb) will increase coverage by 1.20%.
Report is 110 commits behind head on main.
The diff coverage is 91.40%.

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
+ Coverage   86.39%   87.60%   +1.20%     
==========================================
  Files          45       45              
  Lines        7977     8433     +456     
==========================================
+ Hits         6892     7388     +496     
+ Misses       1085     1045      -40     

@germa89 germa89 self-assigned this Sep 4, 2023
@germa89 germa89 enabled auto-merge (squash) September 4, 2023 12:33
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It runs correctly on my local installation as well.
There is no testing of the function though, what would you think about adding a test with a SATIN file created on-the-fly?

@germa89 germa89 merged commit e6d17dc into main Sep 4, 2023
23 checks passed
@germa89 germa89 deleted the feat/improvements-in-satin-command branch September 4, 2023 12:50
@germa89
Copy link
Collaborator Author

germa89 commented Sep 4, 2023

LGTM! It runs correctly on my local installation as well.
There is no testing of the function though, what would you think about adding a test with a SATIN file created on-the-fly?

True. Please do add a test.

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve mapdl.satin command
4 participants