Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing area meshing error in doc build #2319

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Fixing area meshing error in doc build #2319

merged 7 commits into from
Sep 11, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 8, 2023

Close #2313

@germa89 germa89 self-assigned this Sep 8, 2023
@germa89 germa89 enabled auto-merge (squash) September 8, 2023 10:57
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc labels Sep 8, 2023
@germa89 germa89 closed this Sep 8, 2023
auto-merge was automatically disabled September 8, 2023 11:00

Pull request was closed

@germa89 germa89 reopened this Sep 8, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Sep 8, 2023

LGTM!

pyansys-ci-bot
pyansys-ci-bot approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89
Copy link
Collaborator Author

germa89 commented Sep 8, 2023 •
edited

We are seeing here the same fails in test_pick_areas. I believe it is due to the recent update in pyvista #2305

=== EDIT ===
It wasn't because of pyvista. It is because I changed quality and now there are no areas to pick.

@germa89 germa89 enabled auto-merge (squash) September 8, 2023 13:17
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

Merging #2319 (5e6e4f4) into main (a2d1951) will increase coverage by 5.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
+ Coverage   81.79%   87.57%   +5.78%     
==========================================
  Files          45       45              
  Lines        8435     8437       +2     
==========================================
+ Hits         6899     7389     +490     
+ Misses       1536     1048     -488

@germa89 germa89 merged commit 1ff7ae5 into main Sep 11, 2023
21 checks passed
@germa89 germa89 deleted the fix/doc-build-area-meshing-error branch September 11, 2023 16:07
@germa89
Copy link
Collaborator Author

germa89 commented Sep 11, 2023

Finallyyyyy!!!!!!!

@germa89 germa89 mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed scheduled build
2 participants
@germa89 @pyansys-ci-bot