Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing no saving on exit #2342

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 18, 2023

This can be only fixed on MAPDL v24.2 or superior.

Close #1324
Complete work in #2020

@germa89 germa89 requested a review from koubaa September 18, 2023 11:58
@germa89 germa89 self-assigned this Sep 18, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL MAPDL Requires changes in MAPDL labels Sep 18, 2023
@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Sep 18, 2023
@germa89 germa89 enabled auto-merge (squash) September 18, 2023 12:06
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2342 (4890e07) into main (dc64d46) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #2342      +/-   ##
==========================================
- Coverage   87.63%   87.61%   -0.02%     
==========================================
  Files          45       45              
  Lines        8513     8518       +5     
==========================================
+ Hits         7460     7463       +3     
- Misses       1053     1055       +2     

@germa89
Copy link
Collaborator Author

germa89 commented Sep 18, 2023

I'm going to skip the coverage for this PR. It has minimal impact and it will be eventually triggered when we incorporate v24.2 in the CICD.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 18, 2023

It should be v24.1 instead, but because the MAPDL changes has been recently merged in production and the docker image is not updated, let's leave it as it is.

@germa89 germa89 merged commit 7eaa2b2 into main Sep 19, 2023
22 checks passed
@germa89 germa89 deleted the feat/allowing-MAPDL-exiting-without-saving branch September 19, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature MAPDL Requires changes in MAPDL New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database always being saved
2 participants