Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lines to kplot and nplot when using mouse picking #2353

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 21, 2023

As the title.

Close #2275

@germa89 germa89 added the Enhancement Improve any current implemented feature label Sep 21, 2023
@germa89 germa89 self-assigned this Sep 21, 2023
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 21, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Sep 21, 2023

Results

mapdl.ksel("s", "p")

image

mapdl.nsel("s", "p")

image

Small improvement, the selected nodes become slightly bigger.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 21, 2023

Pinging @mcMunich for feedback and testing.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2353 (4b2d7a4) into main (0e14c4d) will decrease coverage by 5.95%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   87.61%   81.66%   -5.95%     
==========================================
  Files          45       45              
  Lines        8518     8527       +9     
==========================================
- Hits         7463     6964     -499     
- Misses       1055     1563     +508     

@germa89
Copy link
Collaborator Author

germa89 commented Sep 21, 2023

#PeopleAreOnHolidays LGTM.

@germa89 germa89 enabled auto-merge (squash) September 21, 2023 11:39
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit d9e48f4 into main Sep 21, 2023
24 checks passed
@germa89 germa89 deleted the feat/adding-lines-to-nplot-and-kplot-when-selecting branch September 21, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: show other entities during nsel or ksel interactive selection
2 participants