Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding files to pull request #2359

Merged
merged 30 commits into from
Oct 2, 2023
Merged

Adding files to pull request #2359

merged 30 commits into from
Oct 2, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 25, 2023

Make CICD to add files to pull request.

@germa89 germa89 self-assigned this Sep 25, 2023
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2359 (1547710) into main (d7fa8ec) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
- Coverage   87.48%   87.42%   -0.06%     
==========================================
  Files          44       44              
  Lines        8455     8455              
==========================================
- Hits         7397     7392       -5     
- Misses       1058     1063       +5     

@germa89
Copy link
Collaborator Author

germa89 commented Sep 25, 2023

Testing commit

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.
This commit won't re-trigger the CICD (since no changes are made in the codebase) therefore
you will see as the actions being with status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 😄

@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.
This commit does not re-trigger the CICD (since no changes are made in the codebase) therefore
you will see as the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.
This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.
This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89
Copy link
Collaborator Author

germa89 commented Sep 25, 2023

== No changes/comment should happen after this ==

@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.
This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89
Copy link
Collaborator Author

germa89 commented Sep 25, 2023

Soo... because we reset the cache every time of all the images, all the images are attached.

We need pyvista/pytest-pyvista#82 to be merged in order to overwrite only the ones that fails.

@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.
This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89 germa89 marked this pull request as ready for review September 28, 2023 16:02
@germa89
Copy link
Collaborator Author

germa89 commented Sep 28, 2023

Ready to review.

In this commit b0ee04d I changed the background for plots. This brokes the tests in the ubuntu local test, which basically get the new image cache and upload them as a commit.
Because the new commit is made by the CICD, it does not retrigger the tests. We will have to do this manually, by submitting an empty commit (this could be automatized probably by using a PAT, but we might end up having infinite-loop)

Later in this 69b2c9a, I have reset the image cache to the one in main, so nothing should get triggered.

Pinging @RobPasMue @jorgepiloto @AlejandroFernandezLuces @clatapie for feedback and/or approval.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/.image_cache/MY_FILE3.png Outdated Show resolved Hide resolved
@germa89 germa89 merged commit 727dde9 into main Oct 2, 2023
26 checks passed
@germa89 germa89 deleted the ci/adding-modified-files-to-pr branch October 2, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants