Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: enhance search bar experience by using pymeilisearch #2368

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Sep 26, 2023

This pull-request enables PyMeilisearch. This tool enhances the user experience when using the search bar.

In ansys/pyfluent@fdf78e4 the option is enabled in the HTML theme configuration.

Later, in a754f43 and b7dc66c, the documentation gets indexed.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2368 (2483d81) into main (d9e48f4) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
- Coverage   87.67%   87.61%   -0.06%     
==========================================
  Files          45       45              
  Lines        8527     8527              
==========================================
- Hits         7476     7471       -5     
- Misses       1051     1056       +5     

@jorgepiloto
Copy link
Member Author

Codecov Report

Merging #2368 (b7dc66c) into main (d9e48f4) will decrease coverage by 6.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
- Coverage   87.67%   81.66%   -6.01%     
==========================================
  Files          45       45              
  Lines        8527     8527              
==========================================
- Hits         7476     6964     -512     
- Misses       1051     1563     +512     

It looks like the coverage is considering the conf.py file... This should not be this way.

Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@jorgepiloto jorgepiloto merged commit 3118480 into main Sep 26, 2023
26 checks passed
@jorgepiloto jorgepiloto deleted the doc/pymeilisearch branch September 26, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants