Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing envvar for connection commands in CICD #2380

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Adding missing envvar for connection commands in CICD #2380

merged 10 commits into from
Nov 21, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 2, 2023 •
edited

Adding missing environment variable.

Close #2377

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Oct 2, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc labels Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited

Codecov Report

Merging #2380 (70c0ed3) into main (949b8d8) will decrease coverage by 0.03%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
- Coverage   83.83%   83.81%   -0.03%     
==========================================
  Files          44       44              
  Lines        8685     8685              
==========================================
- Hits         7281     7279       -2     
- Misses       1404     1406       +2

@germa89 germa89 marked this pull request as draft November 21, 2023 08:41
@germa89 germa89 changed the title Fixing connection commands in CICD Adding missing envvar for connection commands in CICD Nov 21, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2023

I had to downgrade the goals for this PR because fixing connection commands in CICD seems quite difficult and its benefit is yet to be proven.

@germa89 germa89 marked this pull request as ready for review November 21, 2023 09:06
@germa89 germa89 enabled auto-merge (squash) November 21, 2023 09:28
@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 67f9cb0 into main Nov 21, 2023
28 checks passed
@germa89 germa89 deleted the fix/connection-commands-in-cicd branch November 21, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection commands are broken in CICD
2 participants
@germa89 @pyansys-ci-bot