Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix numpy typing import #2395

Merged
merged 6 commits into from
Oct 9, 2023
Merged

fix numpy typing import #2395

merged 6 commits into from
Oct 9, 2023

Conversation

Gryfenfer97
Copy link
Contributor

@Gryfenfer97 Gryfenfer97 commented Oct 6, 2023

  • Fix numpy import of DTypeLike
  • Fix the call to _apply_default_theme() even when pyvista is not installed

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2395 (5ec441a) into main (b84acb7) will increase coverage by 5.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   81.93%   87.88%   +5.95%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
+ Hits         6926     7429     +503     
+ Misses       1527     1024     -503     

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89 germa89 merged commit 9f520cc into main Oct 9, 2023
25 checks passed
@germa89 germa89 deleted the fix/numpy-typing-import branch October 9, 2023 09:18
@koubaa
Copy link
Contributor

koubaa commented Oct 9, 2023

@germa89 @Gryfenfer97 Not urgent - but maybe it makes sense to add a unit test that creates a venv with pymapdl but not pyvista and makes sure mapdl can still be imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants